Another bug, in the cc_show_leads.php

Discussion in 'ClassiCraft WordPress Theme' started by spottedvarennes, Feb 9, 2015.

  1. spottedvarennes

    spottedvarennes Member

    Joined:
    Jan 26, 2015
    Messages:
    79
    Likes Received:
    0
    Found another bug,

    $query = "DELETE FROM $cc_leads_tbl_name WHERE ID = $id";
    $wpdb->query($query);
    $update_msg = LEAD_DELTD;


    Seriously ? So everybody can delete Leads, just by changing the URL arguments? you don't even check if the leads belong to the current User ?
     
  2. spottedvarennes

    spottedvarennes Member

    Joined:
    Jan 26, 2015
    Messages:
    79
    Likes Received:
    0
    Its funny because just a couple of lines below, you do another query to list the leads of the current User....
    SELECT * FROM $cc_leads_tbl_name WHERE post_author = $current_user->ID"

    So change this line DELETE FROM $cc_leads_tbl_name WHERE ID = $id TO

    $query = "DELETE FROM $cc_leads_tbl_name WHERE ID = $id and post_author = $current_user->ID"; Duh!
     
  3. Pramod

    Pramod Guest

    Joined:
    Aug 8, 2014
    Messages:
    2,847
    Likes Received:
    63
    Hello !

    We have noted down all of your suggestions and issues.
    We will try to fix all these issue as well as introduce all suggestions given by you in future updates


    Thanks & Regards
    Pramod Patel
     
  4. malmsteen

    malmsteen Member

    Joined:
    Jan 23, 2015
    Messages:
    73
    Likes Received:
    0
    This is serious bug or what? I need to know the safety measure before I launch my website.
     
  5. Pramod

    Pramod Guest

    Joined:
    Aug 8, 2014
    Messages:
    2,847
    Likes Received:
    63
    Hello !

    I have noted down all issues and suggestions.
    We will try to fix all in next update.

    Thanks & Regards
    Pramod
     

Share This Page