Rethink Theme and translation

Discussion in 'ReThink WordPress Theme' started by tuxlog, Sep 18, 2013.

  1. tuxlog

    tuxlog New Member

    Joined:
    Sep 15, 2013
    Messages:
    3
    Likes Received:
    0
    Hello,

    I have bought the rethink theme and I (re)think it is a really good theme. :)

    Now I want to translate the theme to my language and found that it is a bit messy in preparation for translation.

    • There some words tagged correctly with textdomain "rethink"
    • There a some words tagged incorrectly with textdoamin "spotmoto" (in products.php)
    • And a whole bunch of words isn't tagged at all (e.g. in comments.php).

    Is there a solution for this? Any ideas? Or are there plans to improve this in further releases?

    Thanks in advance, Hans
     
  2. Harmeet

    Harmeet Support Staff

    Joined:
    Oct 19, 2012
    Messages:
    360
    Likes Received:
    15
    Hello,

    Thanks a lot for informing us.
    We will correct it in the theme and update it in next 24 hours.
    And we are bit getting what you are trying to say in this line "And a whole bunch of words isn't tagged at all (e.g. in comments.php)". So could you please explain it more, so that we can check it.
     
  3. tuxlog

    tuxlog New Member

    Joined:
    Sep 15, 2013
    Messages:
    3
    Likes Received:
    0
    Thank you for responding so quickly and for the anncouncement for a quick fix.

    What I mean is if you take a look at e.g. comments.php which is delivered with the rethink theme, you will find various textstrings which are not prepared for translation.
    e.g.
    <p class="nocomments">Comments are closed.</p>
    which probably should be
    <p class="nocomments"><?php _e('Comments are closed','rethink');?>.</p>

    If strings are not preapred for translation by wrapping them into a __ or _e function, it is not possible to translate the theme without editing the original theme files and the work has to be repeated after each update.
    The __ and _e functions are also missing in the complete backend part of the theme.

    I hope I was able to explain what I mean.

    Thank you very much for your support :)
     
  4. tuxlog

    tuxlog New Member

    Joined:
    Sep 15, 2013
    Messages:
    3
    Likes Received:
    0
    Okay, I have added about 200 missing function calls myself. There are also some 404 problems with missing files and some unused code in the theme which I fixed too.
    If you are interested in the corrected version, let me know. Maybe we will find an interesting arrangement for both of us. :)

    Thank you and regards, Hans
     

Share This Page